AP_HAL_ChibiOS: Add hwdef for ARK_CANNODE #22764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexKlimaj can we have a double review on this ? thanks |
andyp1per
force-pushed
the
pr/hwdef-ark-cannode
branch
from
3696e8b
to
b346a33
Compare
andyp1per
force-pushed
the
pr/hwdef-ark-cannode
branch
from
b346a33
to
b3c3e8e
Compare
|
Looking good now. I think the part that was blocking me was my novice level with the stlink. The node boots and can set parameters on the bus now. |
andyp1per
force-pushed
the
pr/hwdef-ark-cannode
branch
from
b3c3e8e
to
15a05db
Compare
andyp1per
force-pushed
the
pr/hwdef-ark-cannode
branch
from
15a05db
to
fd9aea2
Compare
tridge
requested changes
Sep 11, 2023
|
a README.md with description and some photos with pinout would be nice |
andyp1per
force-pushed
the
pr/hwdef-ark-cannode
branch
from
fd9aea2
to
77e8d03
Compare
|
I've added a couple of photos, but none of the periph devices have a readme and certainly none of the ARK devices |
|
Looks good to me. Could add a Readme with the pinout but they are just standard Pixhawk JST-GH. |
tridge
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not tested this on hardware yet (waiting for an stlink to show up in the mail). I don't want to loose the nodes completely without an easy way to get them back. Should be a very capable node! I had a few questions that I wasn't sure how to handle.EDIT: fixed and working now @andyp1per
Schematic and repo for the board is here: https://github.com/ARK-Electronics/ARK_CANNODE/blob/main/Hardware/Rev%201/ARK%20CANNODE%20Rev%201%20Schematic.PDF