Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy use-external-baros #23482

Merged

Conversation

peterbarker
Copy link
Contributor

Note the weirdism around checking definition of AP_BARO_MSP_ENABLED - which will always be defined...

Board               AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal                       *      *           *       *                 *      *      *
HerePro             *                                                                     
Hitec-Airspeed      *                                                                     
KakuteH7-bdshot                *      *           *       *                 *      *      *
MatekF405                      0      *           0       -8                -8     0      -8
Pixhawk1-1M-bdshot             -16                -16     -16               -24    -16    -16
f103-QiotekPeriph   *                                                                     
f303-Universal      *                                                                     
iomcu                                                           *                         
revo-mini                      -16    *           -16     -16               -16    -16    -16
skyviper-v2450                                    *                                       

A lot fo

These are the boards whose hwdefs are being modified. They seem to hae been setting this for no particularly good reason as they were getting the feature anyway.

Board             AP_Periph  blimp  bootloader  copter  heli  plane  rover  sub
F35Lightning                 0      *           -8      -8    0      0      0
FlywooF745Nano               -8     *           -8      -8    0      0      -8
JHEMCU-GSF405A               -8     *           -8      -8    -8     -8     -8
KakuteF7                     8      *           8       16    8      16     16
MatekF405                    0      *           0       -8    -8     0      -8
MatekH743-periph  *                                                         
SuccexF4                     -8     *           -8      -8    -8     -8     -8
f303-Universal    *                                                         
revo-mini                    -16    *           -16     -16   -16    -16    -16
revo-mini-i2c                -8     *           -8      -8    -8     -8     -8
speedybeef4                  0      *           0       0     -8     0      -8

Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, follow the same pattern as other lib

HAL_MINIMIZE_FEATURES handling is moved to minimize_features.inc

AP_BARO_PROBE_EXTERNAL_I2C_BUSES definition is handle by the ap_baro_config.h which is good

@peterbarker peterbarker merged commit 0d8512c into ArduPilot:master Apr 22, 2023
89 checks passed
@peterbarker peterbarker deleted the pr/probe-external-baros-tidy branch April 22, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants