Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ElfinH7 Wing #24543

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

suiaiyun
Copy link

@suiaiyun suiaiyun commented Aug 8, 2023

No description provided.

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes/expansions
also, since this would need a custom bootloader, that you will need to program on the device before shipping and instruction for users how to take the Ardupilot firmware and pack it for loading onto the SD card for your bootloader to push into SPI for execution, we would not want to include an ArduPilot bootloader that would produce code that could overwrite it, so those files need to be removed

I also suggest you send early prototypes to a few ArduPilot devs so that they can verify and help ...Andrew Tridgell, Andy Piper at least...and I would like to have one to verify user instructions on firmware loading as I make the wiki page for the device...

also a link to your website for the device when its ready


## Battery Monitoring

The board has a builting voltage and current sensor. The current sensor can read up to 130 Amps. The voltage sensor can handle up to 6S LiPo batteries.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The board has a builting voltage and current sensor. The current sensor can read up to 130 Amps. The voltage sensor can handle up to 6S LiPo batteries.
The board has a builting voltage sensor and external current sensor input. . The voltage sensor can handle up to 6S LiPo batteries.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction made


The ElfinH7-Wing supports OSD using OSD_TYPE 1 (MAX7456 driver).

## PWM Output
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should state which outputs support DSHOT? BDSHOT? I thihnk you have 1-4 setup for BDSHot

- USB port (with remote cabling)
- CAN port
- External Buzzer
- Dual Switchable Camera inputs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should mention how to control them lower in readme


# GPIOs
PD10 PINIO1 OUTPUT GPIO(81) LOW # Cam Switch
PB15 PINIO2 OUTPUT GPIO(82) LOW # Cam2 Power Switch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which board pins does this control? Vsw?
which pins does the 9v/5v jumper control? which pins does the 12V jumper control(I assume some of the 9V marke pins)?

- Built-in OSD
- microSD card
- Battery input voltage: 2S-6S
- BEC: 1x 5V/2A, 1x 9/12V/2A, 1x 5/6/7.2V/12A
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should mention how to control voltage selection and power control down lower in readme

@suiaiyun
Copy link
Author

suiaiyun commented Aug 9, 2023

I also suggest you send early prototypes to a few ArduPilot devs so that they can verify and help ...Andrew Tridgell, Andy Piper at least...and I would like to have one to verify user instructions on firmware loading as I make the wiki page for the device...

Hello, do you need to mail it to the developers? May I ask where the address is? At present, this board only has a prototype board and has not started production. If necessary, I can mail the prototype board to the developers.

also a link to your website for the device when its ready

There is currently no relevant website available. If necessary, I will create a corresponding website.

@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Aug 9, 2023

I also suggest you send early prototypes to a few ArduPilot devs so that they can verify and help ...Andrew Tridgell, Andy Piper at least...and I would like to have one to verify user instructions on firmware loading as I make the wiki page for the device...

Hello, do you need to mail it to the developers? May I ask where the address is? At present, this board only has a prototype board and has not started production. If necessary, I can mail the prototype board to the developers.

also a link to your website for the device when its ready

There is currently no relevant website available. If necessary, I will create a corresponding website.

  1. There is no requirement to send the boards, but it will allow us to provide assistance during your development, help assure nothing is overlooked and provide a means to help answer questions on any issues that might arise from you or your customers more quickly.
  2. if you want to do that then just put your email address here and I will have the addresses emailed to you
  3. having a link to where users will be able to obtain these devices is only needed when the wiki page is to be posted....posting that page (After your PR is merged) can wait until such time its is offered for sale...

@suiaiyun
Copy link
Author

suiaiyun commented Aug 9, 2023

There is no requirement to send the boards, but it will allow us to provide assistance during your development, help assure nothing is overlooked and provide a means to help answer questions on any issues that might arise from you or your customers more quickly.

This is great. Do I need to provide the schematic diagram of the board to the developers? As this is the first time submitting a PR for a new board, please forgive me for not clarifying what needs to be sent to the developers.

@Hwurzburg
Copy link
Collaborator

There is no requirement to send the boards, but it will allow us to provide assistance during your development, help assure nothing is overlooked and provide a means to help answer questions on any issues that might arise from you or your customers more quickly.

This is great. Do I need to provide the schematic diagram of the board to the developers? As this is the first time submitting a PR for a new board, please forgive me for not clarifying what needs to be sent to the developers.

having a schematic is always helpful....we are very careful to use only with lead developers...
I have discussed internally and the plane lead feels it important that I get a board as soon as possible to run user oriented trials on the external QSPI setup....its new and only one dev has played with this function....if that is possible....my email is hwurzburg@yahoo.com and I can send you details if you wish

@suiaiyun
Copy link
Author

having a schematic is always helpful....we are very careful to use only with lead developers... I have discussed internally and the plane lead feels it important that I get a board as soon as possible to run user oriented trials on the external QSPI setup....its new and only one dev has played with this function....if that is possible....my email is hwurzburg@yahoo.com and I can send you details if you wish

Hello. The schematic diagram of the ElfinH7 Wing board has been sent to your email. Thank you for your review.

@Hwurzburg
Copy link
Collaborator

@suiaiyun any updates? is the project still alive?

@suiaiyun
Copy link
Author

@suiaiyun any updates? is the project still alive?

Yes, it is still alive, but encountered a problem. I asked a question in the discussion, but did not receive a clear response. https://discuss.ardupilot.org/t/plane-4-4-release/99954/141

@Hwurzburg
Copy link
Collaborator

that is because you are using customized code,and Tridge wont spend much time on trying to figure out what wrong....I would test this PR on master so CAN support is there, with normal param storage,not on sd card....then if this is proven and working on your controller, this PR can go into master...THEN you can do customized things like sd card param storage,etc.
also you need to get boards to Tridge,etc if you expect real help bringing up a new board...also, reserve the board id separately in a separate PR asap

@Hwurzburg
Copy link
Collaborator

@suiaiyun any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants