AP_BattMonitor: extend AP_BATT_MONITOR_MAX_INSTANCES to 16 #24660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AP_BattMonitor: extend AP_BATT_MONITOR_MAX_INSTANCES limit to 16 (default is still 9)
Doesn't hurt to bump the max up to 16, especially for vehicles with lots of power monitoring and AP_Periphs with sensors galore!
Note: if we ever consider pushing above 16 The limitation is param1 being treated as uint16 in handle_command_battery_reset()
Since it's a command_long, the float could give us 24 bitmask bits as-is. The MAVLink docs don't mention any limit but since packet.param1 is a float we could change it to 32bit and do:
which would allow a GCS to clear them all (including SITL autotest) without having to know how many there are and thus support up to 32 gracefully-ish.
In fact, I've also made PR #24661 on top of this branch that I made for the LOLs.