AP_Mount: In Siyi, add check for minimum supported firmware version #24915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexton-winjeel
force-pushed
the
upstream/siyi-warn-old-firmware
branch
from
2da7d2f
to
2ae9fdc
Compare
rmackay9
reviewed
Sep 8, 2023
rmackay9
reviewed
Sep 8, 2023
rmackay9
reviewed
Sep 8, 2023
|
Hi @nexton-winjeel, this is really great, thanks for this. As per usual I've added nitpicky naming and formatting requests in my review but overall I think this will be a really great feature. |
nexton-winjeel
force-pushed
the
upstream/siyi-warn-old-firmware
branch
from
2ae9fdc
to
8021a20
Compare
rmackay9
reviewed
Sep 8, 2023
nexton-winjeel
force-pushed
the
upstream/siyi-warn-old-firmware
branch
from
8021a20
to
2a7080e
Compare
rmackay9
approved these changes
Sep 8, 2023
rmackay9
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Siyi driver is in active development, and may be using features that are only available in the latest firmware. This PR adds a check to make sure that the connected Siyi gimbal is running a supported firmware version.
Tested on Siyi A8.
FYI: @rmackay9