Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_TempertureSensor:clarify temp source for pitot tube #24986

Merged
merged 1 commit into from
Sep 19, 2023
Merged

AP_TempertureSensor:clarify temp source for pitot tube #24986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/AP_TemperatureSensor/AP_TemperatureSensor_Params.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const AP_Param::GroupInfo AP_TemperatureSensor_Params::var_info[] = {
// @Param: SRC
// @DisplayName: Sensor Source
// @Description: Sensor Source is used to designate which device's temperature report will be replaced by this temperature sensor's data. If 0 (None) then the data is only available via log. In the future a new Motor temperature report will be created for returning data directly.
// @Values: 0: None, 1:ESC, 2:Motor(not implemented yet), 3:Battery Index, 4:Battery ID/SerialNumber, 5: Pitot tube
// @Values: 0: None, 1:ESC, 2:Motor(not implemented yet), 3:Battery Index, 4:Battery ID/SerialNumber, 5: CAN based Pitot tube
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magicrub says the pitot tube option isn't implemented yet, so lets just remove it from the list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, lets remove "Pitot tube" enum for now until I get my AP_Heater library merged in which will use it. The enum is currently a placeholder but I agree that it's creating confusion right now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tridge but this is only part of a larger code change...and the enum impacts this code, not just the switch statement.....its the reason I said this is CAN specific: #24462
should that CAN change be reverted also?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hwurzburg fair enough. Let's go ahead and merge this as-is if you think this change helps with the confusion. I'll get the AP_Heater in at some point to bring better utility to it. It's kind of a hack at the moment and it's been backburnered for over a year to upstream it. For now the enum is useful for logging purposes in it's current form.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I posted a PR that removes the unused ENUM as Tridge suggested...you guys decide

// @User: Standard
AP_GROUPINFO("SRC", 4, AP_TemperatureSensor_Params, source, (float)Source::None),

Expand Down