New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plane: rework set_servos_controlled function #25371

Merged

tridge merged 1 commit into ArduPilot:master from IamPete1:plane_set_servos_controlled_rework

Oct 31, 2023

Member

IamPete1 commented Oct 25, 2023

A relatively small rework to pave the way for future clean ups.

reworks the flight_stage_determines_max_throttle calculation. Result is the same but method is less confusing.
always outputs 0 scaled throttle is !is_armed_and_safety_off(), this prevents a miss match between the scaled value and the output PWM value that can cause slew limits and other functions that use the scaled value to get confused.
moves the unrelated set_takeoff_expected functionality to its own function.


          Plane: rework set_servos_controlled function

c079cad

IamPete1 added Plane DevCallTopic labels

CraigElder removed the DevCallTopic label

tridge approved these changes

View reviewed changes

tridge merged commit 7e4b5b0 into ArduPilot:master

56 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment