Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new board PixFlamingo F7 #25714

Merged

Conversation

tsubashchandar
Copy link
Contributor

Added new board

@tsubashchandar
Copy link
Contributor Author

how to include this hw into 4.4.3 branches , Kindly help on this

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs pinouts,bd photos,typical wriring diagram, where to buy in a readme file....see https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7-Wing/README.md for an example

also needs the bootloader files in the Tools/bootloaders directory

@tsubashchandar
Copy link
Contributor Author

needs pinouts,bd photos,typical wriring diagram, where to buy in a readme file....see https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7-Wing/README.md for an example

also needs the bootloader files in the Tools/bootloaders directory

I have updated the changes .Kindly check this

@Hwurzburg
Copy link
Collaborator

@tsubashchandar thanks, readme started but fairly incomplete...refer to example given..still needs board photo, where to buy,wiring/pinouts...also uart section needs dma capabilities, etc.

@IamPete1
Copy link
Member

I have rebased and fixedup the commit history.

@IamPete1
Copy link
Member

Added dev call tag so we won't forget to follow up.

@tsubashchandar
Copy link
Contributor Author

I have rebased and fixedup the commit history.

Thanks

@tsubashchandar
Copy link
Contributor Author

@IamPete1 @Hwurzburg I have made the changes .

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needs DMA comments fixed...needs rebase, squash, library commits split into two commits wwith proper commit messages, see Tools/gittools/git-subsystems split utility

- SERIAL3 -> UART1 (GPS1) DMA Enabled
- SERIAL4 -> EMPTY
- SERIAL5 -> UART7 (GPS2) NODMA
- SERIAL6 -> USART2 (User) DMA Enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- SERIAL6 -> USART2 (User) DMA Enabled
- SERIAL6 -> USART2 (User) RX only is DMA Enabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

libraries/AP_HAL_ChibiOS/hwdef/PixFlamingo-F767/README.md Outdated Show resolved Hide resolved
@tsubashchandar
Copy link
Contributor Author

@Hwurzburg @IamPete1 I have fixed the review comments, only hwdef files I changed , other files need to be rebased , help me on that

@IamPete1
Copy link
Member

IamPete1 commented Mar 4, 2024

Squashed and rebased. @tsubashchandar You should now pull this branch down to your local repo so any further changes are added on top. You should also prefix your commit messages with the subsystem they changing, in this case AP_HAL_ChibiOS:

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Mar 4, 2024
@tridge
Copy link
Contributor

tridge commented Mar 4, 2024

@Hwurzburg will check that the requested changes have been made

@IamPete1 IamPete1 merged commit 7db7f95 into ArduPilot:master Mar 4, 2024
42 checks passed
@tsubashchandar
Copy link
Contributor Author

@IamPete1 @IamPete1 how to backport to 4.4 or 4.5 branch ?

@IamPete1
Copy link
Member

IamPete1 commented Mar 5, 2024

Too late for 4.4. I have marked for 4.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WikiNeeded needs wiki update
Projects
Status: 4.5.0-beta3
Development

Successfully merging this pull request may close these issues.

None yet

5 participants