Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC_WPNav: ACCEL_C defaults to 2x ACCEL #25928

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Jan 8, 2024

We've had numerous support issues involving users complaining that Copter-4.4 doesn't cut the corners as much as is it in previous versions. The advice to users has been to set WPNAV_ACCEL_C to 2x the WPNAV_ACCEL value to get back to the behaviour they had in previous versions. This PR makes the default WPNAV_ACCEL_C produce this behaviour.

This changes the maximum cornering acceleration to be 2x the regular waypoint acceleration (previously was 1x).

Increasing this acceleration results in the WPNAV_RADIUS parameter being the most likely limitation to how widely SCurves corners are cut.

Below are before-vs-after screen shots of the path taken during a rectangular mission with WPNAV_RADIUS = 5000 (e.g. 50m).
before-vs-after-radius50

Here are before-vs-after screen shots when WPNAV_RADIUS = 200 (e.g. 2m which is the default) and we see there's no obvious change in behaviour.
before-vs-after-radius2

Copy link
Contributor

@lthall lthall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think this is the right thing to do. I went with the conservative approach first but this gives the most efficient flight profile.

@andyp1per
Copy link
Collaborator

Candidate for 4.4 maybe?

@amilcarlucas
Copy link
Contributor

This is probably the only 4.4 regression. So I would say yes.

@rmackay9
Copy link
Contributor Author

rmackay9 commented Jan 8, 2024

Yes, good idea. I've added it to the 4.4 project and I suspect we will have a 4.4.5 soon.

@rmackay9 rmackay9 merged commit 0cf6160 into ArduPilot:master Jan 8, 2024
90 checks passed
@rmackay9
Copy link
Contributor Author

rmackay9 commented Jan 8, 2024

OK, two approvals so in it goes!

@rmackay9 rmackay9 added this to Pending in Copter-4.4 Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Copter-4.4
Pending
Plane 4.4
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

5 participants