AC_WPNav: ACCEL_C defaults to 2x ACCEL #25928
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had numerous support issues involving users complaining that Copter-4.4 doesn't cut the corners as much as is it in previous versions. The advice to users has been to set WPNAV_ACCEL_C to 2x the WPNAV_ACCEL value to get back to the behaviour they had in previous versions. This PR makes the default WPNAV_ACCEL_C produce this behaviour.
This changes the maximum cornering acceleration to be 2x the regular waypoint acceleration (previously was 1x).
Increasing this acceleration results in the WPNAV_RADIUS parameter being the most likely limitation to how widely SCurves corners are cut.
Below are before-vs-after screen shots of the path taken during a rectangular mission with WPNAV_RADIUS = 5000 (e.g. 50m).
Here are before-vs-after screen shots when WPNAV_RADIUS = 200 (e.g. 2m which is the default) and we see there's no obvious change in behaviour.