Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run_in_terminal_window.sh #26921

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

Silipwn
Copy link
Contributor

@Silipwn Silipwn commented Apr 29, 2024

Remove the TERM variable dependency.

Usually, the TERM variable is user's preference.

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Apr 29, 2024

What environment does this not currently work on master branch?

@Silipwn
Copy link
Contributor Author

Silipwn commented Apr 30, 2024

I can explain my case here.

I usually work in a TMUX environment, but I have the $TERM variable set to tmux-256color to enable full color support. ref

And it's not necessary that you'd have the $SCREEN variable set to screen (Even though that's the default config).
Removing the check for $TERM just makes it easier for everyone to use this.

Remove the TERM variable dependency
@peterbarker
Copy link
Contributor

Fixed the commit message.

@peterbarker peterbarker merged commit 20a23d8 into ArduPilot:master May 21, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants