Tools: fix checking of hwdef includes for Periph #27139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix scans all the include files in a hwdef, not just one on the first line.
robertlong13
changed the title
robertlong13
changed the title
peterbarker
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue where an AP_Periph hwdef I was working on started failing when I added a comment to the top of the file. In fact, it was failing if the include was anywhere except at the very top. To reproduce the bug on master, place a line-break at the top of
libraries/AP_HAL_ChibiOS/hwdef/AeroFox-Airspeed/hwdef.datand try to compile.When waf was trying to determine which boards AP_Periph could compile for, it did not correctly follow includes. It only considered one include at the very beginning of the file. This fixes that so it correctly scans through all includes, wherever they are in the hwdef.