Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waf: git_submodule: fix uid() method for python3 #3646

Closed
wants to merge 1 commit into from
Closed

waf: git_submodule: fix uid() method for python3 #3646

wants to merge 1 commit into from

Conversation

guludo
Copy link
Contributor

@guludo guludo commented Feb 19, 2016

Python3's hashlib.md5() requires Unicode-objects to be encoded before hashing.

Python3's hashlib.md5() requires Unicode-objects to be encoded before hashing.
@magicrub
Copy link
Contributor

is this specific to python3?

@guludo
Copy link
Contributor Author

guludo commented Feb 19, 2016

@magicrub The enconding requirement is python3-specific, but the fix works for both python2 and python3.

@magicrub
Copy link
Contributor

I was hoping this would fix the windows SITL bug where python is crashing. Maybe it helps?

@guludo
Copy link
Contributor Author

guludo commented Feb 19, 2016

Do you mean this #3586 ? If so, it's unrelated.

By the way, I haven't tried using the waf based build system on windows yet hehe
Plan to do it soon.

@magicrub
Copy link
Contributor

That is what I meant.

On Fri, Feb 19, 2016 at 9:13 AM, Gustavo José de Sousa <
notifications@github.com> wrote:

Do you mean this #3586
#3586 ? If so, it's
unrelated.

By the way, I haven't tried using the waf based build system on windows
yet hehe
Plan to do it soon.


Reply to this email directly or view it on GitHub
#3646 (comment).

@lucasdemarchi
Copy link
Contributor

That bug should be fixed in mavlink repository, not in ardupilot. mavgen.py is crashing... @magicrub could you provide the message when running mavgen in windows? @tridge tried waf on windows, but it's crashing on mavgen, just like with the make build system.

@guludo
Copy link
Contributor Author

guludo commented Feb 19, 2016

@lucasdemarchi This fix is unrelated to that. Just to be clear :-)

@lucasdemarchi
Copy link
Contributor

@guludo yes, I know... I was explaining that to @magicrub

@lucasdemarchi
Copy link
Contributor

Applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants