Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUAVX21 bootloader #7104

Closed
wants to merge 3 commits into from
Closed

Conversation

kd0aij
Copy link
Contributor

@kd0aij kd0aij commented Oct 22, 2017

moves px_uploader.py from modules/PX4Firmware to Tools/scripts
and adds support for the AUAVX2.1 with its new board ID of 33
Also adds the concept of a compatibility list matching board IDs to firmware IDs.

@OXINARF
Copy link
Member

OXINARF commented Oct 23, 2017

@kd0aij I guess the request to copy the script from the submodule into this repo came from @tridge?
I'm not against it, but we need to change our tools to use it, otherwise it's pointless.

I'm not sure if @lucasdemarchi likes this though, it will make it harder to port fixes from PX4.

@lucasdemarchi
Copy link
Contributor

If it's going to be used for other HALs like the chibios one, it's a sane thing to do. Of it's only for boards with px4firmware, I don't see an advantage.

@kd0aij
Copy link
Contributor Author

kd0aij commented Oct 23, 2017

@OXINARF Right, I originally created ArduPilot/archived-PX4Firmware#81 against PX4/Firmware and tested there. But @tridge prefers to do it this way in order to also support chibios.
Not quite pointless, though, since it does work from the command line :)

@OXINARF
Copy link
Member

OXINARF commented Oct 24, 2017

Not quite pointless, though, since it does work from the command line :)

@kd0aij We probably can count with one hand the number of people using it directly from the command line 🙂

@kd0aij kd0aij added WIP and removed DevCallTopic labels Nov 10, 2017
@kd0aij
Copy link
Contributor Author

kd0aij commented Nov 17, 2017

This PR will be completed when support for ChibiOS is added

@magicrub
Copy link
Contributor

magicrub commented Apr 2, 2018

what's status on this? @kd0aij says it's ready when there's ChibiOS support. It has arrived.

@khancyr
Copy link
Contributor

khancyr commented Mar 1, 2019

do we still need this ?

@kd0aij
Copy link
Contributor Author

kd0aij commented Mar 1, 2019

@magicrub @tridge I had forgotten about this, and don't know whether this functionality has since been implemented in some other way. IIRC, my comment that it "will be completed" meant that Tridge would integrate it eventually :)
I assume that the X21 is handled correctly by GCSs, but I haven't tested that myself lately.

@tridge
Copy link
Contributor

tridge commented Mar 1, 2019

we don't need the rename of the script as that has been done and the script is now Tools/scripts/uploader.py
I'm not sure about the compatible IDs change. I suspect that is still needed. Can you rework it to just have that change against master?

@kd0aij
Copy link
Contributor Author

kd0aij commented Mar 2, 2019

new PR: #10683

@kd0aij kd0aij closed this Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants