Slew rate 2 #8228
Open
Slew rate 2 #8228
+73
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com> Co-authored-by: Jacob Walser <jwalser90@gmail.com>
|
Use float multiplication, not division. |
OXINARF
requested changes
May 23, 2018
| // Apply rate of change limiting to an input | ||
| // max_rate is the maximum allowed rate of change as a percentage of the range per second | ||
| // dt is the time delta in seconds between calls | ||
| void limit_value_slew_rate(float& previous, float& current, float range, float max_rate, float dt) { |
There was a problem hiding this comment.
The limit_demand_slew_rate method is already big to be in the header, but this one is huge. Please move it to the cpp file.
| max_change = 0.001 * range; | ||
| } | ||
|
|
||
| current = constrain_float(current, previous - max_change, previous + max_change); |
There was a problem hiding this comment.
I wonder if limit.X should be set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one supercedes #8213 and is revised according to review in dev call.