AP_RangeFinder: Make the first driver _TYPE an enable parameter #8698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is pending adding a 2-level system for enable parameters |
|
Pending a 2 level enable system for parameters, which does not look to be a high priority for anyone at the moment, and this is a small change/not a priority. Closing until such time as we have that available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4599
This is a bit of a debate, without this change we can't hide the parameters, hiding the parameters for those who aren't using rangefinders removes 38 parameters, however it requires that the first rangefinder instance be the first one the user configures/enables, which is a bit of a behavior change. I'm fine with it either way, but if we don't want to go down this path then we should close the linked issue out as something that won't be resolved.