ardupilot: added more EFI status variables #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I`m going to port this upstream next week. But Please remove the duplicated unit information in the description fields. |
tridge
force-pushed
the
pr-efi-extensions
branch
from
73240b1
to
73e2811
Compare
sure, done, thanks |
peterbarker
reviewed
Jan 6, 2020
| <field type="float" name="cylinder_head_temperature" units="degC">cylinder_head_temperature</field> | ||
| <field type="float" name="ignition_timing" units="deg">Ignition timing (Crank Angle degrees)</field> | ||
| <field type="float" name="injection_time" units="ms">Injection time</field> | ||
| <extensions/> |
There was a problem hiding this comment.
Should we really bother making these extensions? How many users of this message are there?
|
Might as well put them in. |
|
On Mon, 6 Jan 2020, auturgy wrote:
Might as well put them in.
FYI mavlink#1264 and #122
To be clear, I meant "make them normal fields". i.e. actively break older
implementations.
|
|
Ah, got it.
It’s a mavlink1 ID, but if they fit, sure. Deciding which fields go inside the message and which should be extensions would be worth a discussion.
I think Spektreworks are the only users with this fielded.
Regards,
James
… On 6 Jan 2020, at 10:45 pm, Peter Barker ***@***.***> wrote:
On Mon, 6 Jan 2020, auturgy wrote:
> Might as well put them in.
> FYI mavlink#1264 and #122
To be clear, I meant "make them normal fields". i.e. actively break older
implementations.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are needed for the EMU ECU:
ArduPilot/ardupilot#12874