common.xml: deprecate the _INT frames #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
approved these changes
Mar 11, 2024
|
Sounds good to me. We can't really remove the _INT any time soon but marking them deprecated at least removes some essentially identical options that could lead to confusion. |
|
The upstream PR is much-improved from this one; I'll be resetting the content of this PR to whatever gets merged upstream at this point. |
* common.xml: deprecate the _INT frames the frame of an altitude is not dependent on how the altitude is being transported (how other fields in the same message are being transported). ArduPilot has treated these frames to be the same as the non-_INT equivalents in most places for a very long time. We can save some confusion and perhaps a small amount of flash space if we remove the _INT frames * Replace the deprecated types where they are used * Rename lat/lon from X pos/Y pos in WGS84 frame * Update message_definitions/v1.0/common.xml * simply the global frames * Apply suggestions from code review * Apply suggestions from code review * Update common.xml --------- Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
peterbarker
force-pushed
the
pr/deprecate-int-frames-ardupilot
branch
from
3653741
to
fb5d56c
Compare
|
I've reset the content of this PR to be the much-improved-by- @hamishwillee version merged into mavlink/mavlink |
|
@peterbarker Really appreciate all this cleanup stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the frame of an altitude is not dependent on how the altitude is being transported (how other fields in the same message are being transported).
ArduPilot has treated these frames to be the same as the non-_INT equivalents in most places for a very long time.
We can save some confusion and perhaps a small amount of flash space if we remove the _INT frames
Upstream PR is here: mavlink#2092