New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enum values larger than Java max int #678
Conversation
@peterbarker and @magicrub - @TSC21 mentioned that this might be a slight improvement (compatibility-wise) to https://github.com/ArduPilot/pymavlink/pull/639/files |
no objection here. If it compiles and works then ok |
Hi @magicrub - I tested against the current RAS-A IOP Specification and it generates Java message definitions that compile. |
@radarku woah, didn't realize this is still pending.. sorry about that! Thanks for updating it with master with a merge but we don't merges in PRs. Please rebase on master instead. |
@radarku needs rebase due to conflicts |
@radarku I've merged another PR which was essentially identical to this one - simply because this one needs rebasing and the other didn't. Thanks for looking at this! (and thanks for @shancock884 for sorting all this out again) |
Fix to the Java generator for enum values that are larger than Java maximum integer size.
Without this PR, mavgen would produce MAVLink library code that cannot compile. This change preserves existing interoperability (i.e., current source code that expects integer enums and int types for Java switch statements), while also allowing larger enum values.