Deal with avr-gcc 14.1.0 fallout #1240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file included from /opt/arduino/libraries/IRremote/IRremote.hpp:278,
from /home/ice/u0/leres/src/sxmmodu/ir.cpp:34:
/opt/arduino/libraries/IRremote/LongUnion.h:90:7: error: declaration of 'LongUnion::<unnamed struct> LongUnion::WordUnion' changes meaning of 'WordUnion' [-Wchanges-meaning]
90 | } WordUnion;
| ^~~~~~~~~
/opt/arduino/libraries/IRremote/LongUnion.h:89:9: note: used here to mean 'union WordUnion'
89 | WordUnion HighWord;
| ^~~~~~~~~
/opt/arduino/libraries/IRremote/LongUnion.h:36:7: note: declared here
36 | union WordUnion {
| ^~~~~~~~~
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jun 16, 2024
Also deal with avr-gcc 14.1.0 fallout:
Arduino-IRremote/Arduino-IRremote#1240
Changes since 4.3.1:
- Added sendSonyMSB(unsigned long data, int nbits) as a clone of
sendSony(unsigned long data, int nbits) to be more consistent.
- Added sendSamsungMSB(unsigned long data, int nbits) as a clone
of sendSAMSUNG(unsigned long data, int nbits) to be more consistent.
- Added ESP32 core 3.x error message.
Reported by: portscout
|
Thanks for reporting. Is it OK when I use some other names and do not merge your PR? |
Of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD bumped avr-gcc from 11.2.0_3 to 14.1.0 which is a bit more picky about union definitions:
This PR makes minimal changes to get it to compile again.