Added validations DBA.FR74a and DBA.FR74b and related conformance tests. #1308
Conversation
allenbross-wf
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
allenbross-wf
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
allenbross-wf
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
allenbross-wf
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
allenbross-wf
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
allenbross-wf
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| elif fact.qname == pluginData.liabilitiesOtherThanProvisionsQn and fact.unit.value == DANISH_CURRENCY: | ||
| liabilityOtherFact = fact | ||
| if equityFact is not None and liabilityFact is not None and provisionFact is not None: | ||
| if cast(float, liabilityFact.xValue) - cast(float, equityFact.xValue) < cast(float, provisionFact.xValue) - ROUNDING_MARGIN: |
There was a problem hiding this comment.
Is this safe without xValue >= VALID? (Here or elsewhere in the plugin.)
| elif fact.qname == pluginData.liabilitiesOtherThanProvisionsQn and fact.unit.value == DANISH_CURRENCY: | ||
| liabilityOtherFact = fact | ||
| if equityFact is not None and liabilityFact is not None and provisionFact is not None: | ||
| if cast(float, liabilityFact.xValue) - cast(float, equityFact.xValue) < cast(float, provisionFact.xValue) - ROUNDING_MARGIN: |
There was a problem hiding this comment.
Are these actually xs:float, or would decimal.Decimal be better?
There was a problem hiding this comment.
These xValues are actually floats.
There was a problem hiding this comment.
The LiabilitiesAndEquity concept is xbrli:monetaryItemType, which extends xs:decimal. I believe this logic should be producing decimal.Decimal. When I run fr74a-invalid.xbrl, I see <class 'decimal.Decimal'> for type(liabilityFact.xValue), not <class 'float'>, so cast(float) seems wrong.
| NAMESPACE_CMN = 'http://xbrl.dcca.dk/cmn' | ||
| NAMESPACE_FSA = 'http://xbrl.dcca.dk/fsa' | ||
| NAMESPACE_GSD = 'http://xbrl.dcca.dk/gsd' | ||
| NAMESPACE_SOB = 'http://xbrl.dcca.dk/sob' | ||
| ROUNDING_MARGIN = 1000 |
There was a problem hiding this comment.
Out of curiosity, where does this value come from?
There was a problem hiding this comment.
This came from the validation spreadsheet: "There is an option to deviate by DKK 1000 in connection with any roundings"
There was a problem hiding this comment.
This looks like a constant rather than an option.
Reason for change
Description of change
Added validations and conformance tests.
Steps to Test
review:
@Arelle/arelle