Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NL FR KVK 2.01 validation #874

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

aaroncameron-wk
Copy link
Contributor

Description of change

FR-KVK-2.01: The XBRL instance root node MUST contain attribute "xml:lang" with value "nl", "en", "de" or "fr"

Steps to Test

python arelleCmdLine.py -f ./tests/resources/validation/NL/example/a.xbrl 
--plugins="validate/NL" --validate --disclosureSystem NT17-preview

Result: no NL validation errors


python arelleCmdLine.py -f ./tests/resources/validation/NL/fr_kvk/2.01/fail/invalid.xbrl 
--plugins="validate/NL" --validate --disclosureSystem NT17-preview

Result: Errors include [NL.FR-KVK-2.01] The XBRL instance root node MUST contain attribute "xml:lang" with one of the following values: de, en, fr, nl. Provided: zz - invalid.xbrl


python arelleCmdLine.py -f ./tests/resources/validation/NL/fr_kvk/2.01/fail/missing.xbrl 
--plugins="validate/NL" --validate --disclosureSystem NT17-preview

Result: Errors include [NL.FR-KVK-2.01] The XBRL instance root node MUST contain attribute "xml:lang" with one of the following values: de, en, fr, nl. Provided: (none) - missing.xbrl

review:
@Arelle/arelle

@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests September 25, 2023 22:50 — with GitHub Actions Inactive
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@derekgengenbacher-wf
Copy link
Contributor

QA +10 Testing locally succeeded.

@derekgengenbacher-wf derekgengenbacher-wf merged commit 72aa068 into Arelle:master Sep 26, 2023
88 checks passed
yield Validation.error(
codes='NL.FR-KVK-2.01',
msg=_('The XBRL instance root node MUST contain attribute "xml:lang" with one of the following values: %(acceptedLangs)s. Provided: %(lang)s'),
modelObject=doc,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, would doc.xmlRootElement be more appropriate?

@aaroncameron-wk aaroncameron-wk deleted the fr-kvk-2-01 branch April 3, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

5 participants