-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NL.FR-NL-1.01 testcase #920
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
had a problem deploying
to
integration-tests
October 19, 2023 18:19
— with
GitHub Actions
Error
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
aaroncameron-wk
temporarily deployed
to
integration-tests
October 20, 2023 16:48
— with
GitHub Actions
Inactive
stevenbronson-wk
approved these changes
Oct 20, 2023
allenbross-wf
approved these changes
Oct 20, 2023
QA +10 CI Passed successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
FR-NL-1.01: A BOM character MUST NOT be used
A BOM (Byte Order Mark) is a unicode character that represents the byte order in a file:
16 or 32 bits. Within the UTF-8 standard, this is an optional, but unnecessary, character (because the 8
stands for 8 bits).
This rule cannot be implemented using XBRL Formula since the BOM
character is a physical document attribute that is not available in the logical document model
used by XPath.
Description of change
Like the validation checking for a CDATA end sequence, we shouldn't rely on a parsed XML model to find this character, as there's no guarantee that XML parsing won't trim/ignore it wherever it may be included in a document. This PR makes a reusable
findDisallowedPatterns
function (with a cached result so the instance documents don't need to be loaded multiple times) to check for the CDATA sequence, a BOM character, or any other pattern that makes sense to be checked for this way.Steps to Test
CI
review:
@Arelle/arelle