Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NL.FR-NL-1.01 testcase #920

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

aaroncameron-wk
Copy link
Contributor

Reason for change

FR-NL-1.01: A BOM character MUST NOT be used
A BOM (Byte Order Mark) is a unicode character that represents the byte order in a file:
16 or 32 bits. Within the UTF-8 standard, this is an optional, but unnecessary, character (because the 8
stands for 8 bits).
This rule cannot be implemented using XBRL Formula since the BOM
character is a physical document attribute that is not available in the logical document model
used by XPath.

Description of change

Like the validation checking for a CDATA end sequence, we shouldn't rely on a parsed XML model to find this character, as there's no guarantee that XML parsing won't trim/ignore it wherever it may be included in a document. This PR makes a reusable findDisallowedPatterns function (with a cached result so the instance documents don't need to be loaded multiple times) to check for the CDATA sequence, a BOM character, or any other pattern that makes sense to be checked for this way.

Steps to Test

CI

review:
@Arelle/arelle

@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@aaroncameron-wk aaroncameron-wk temporarily deployed to integration-tests October 20, 2023 16:48 — with GitHub Actions Inactive
@allenbross-wf
Copy link
Contributor

QA +10 CI Passed successfully

@allenbross-wf allenbross-wf merged commit d72f455 into Arelle:master Oct 20, 2023
90 of 91 checks passed
@aaroncameron-wk aaroncameron-wk deleted the fr-nl-1-01 branch December 19, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

5 participants