Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icons for exchanges #7

Merged
merged 28 commits into from
May 24, 2023
Merged

feat: add icons for exchanges #7

merged 28 commits into from
May 24, 2023

Conversation

alfonsobries
Copy link
Member

Summary

Related to https://app.clickup.com/t/861mruhvw

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link
Member

@alexbarnsley alexbarnsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the id's have been overwritten. e.g. arkscan/icons/bingx.svg has id="a". you'll need to replace all these instances with id="keep_whatevertheidis". if they all use the same they'll mess with each other when on the same page

@alexbarnsley alexbarnsley marked this pull request as draft May 23, 2023 21:59
@alfonsobries alfonsobries marked this pull request as ready for review May 23, 2023 22:19
Copy link
Member

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfonsobries there are still a couple SVGs that rely on short ids that need adjusting to avoid clashes, otherwise the url reference picks whatever is last and results in weird styles

arkscan/icons/letsexchange.svg Outdated Show resolved Hide resolved
arkscan/icons/bingx.svg Outdated Show resolved Hide resolved
arkscan/icons/bitexen.svg Outdated Show resolved Hide resolved
arkscan/icons/coinex.svg Outdated Show resolved Hide resolved
arkscan/icons/coinspot.svg Outdated Show resolved Hide resolved
arkscan/icons/exodus.svg Outdated Show resolved Hide resolved
arkscan/icons/bitladon.svg Outdated Show resolved Hide resolved
@ItsANameToo ItsANameToo marked this pull request as draft May 24, 2023 11:16
@alfonsobries alfonsobries marked this pull request as ready for review May 24, 2023 16:07
@alfonsobries
Copy link
Member Author

@ItsANameToo updated with a more unique id

@ItsANameToo ItsANameToo merged commit a3bfa89 into master May 24, 2023
@ItsANameToo ItsANameToo deleted the feat/add-icons branch May 24, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants