-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add icons for exchanges #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the id's have been overwritten. e.g. arkscan/icons/bingx.svg
has id="a"
. you'll need to replace all these instances with id="keep_whatevertheidis"
. if they all use the same they'll mess with each other when on the same page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfonsobries there are still a couple SVGs that rely on short ids
that need adjusting to avoid clashes, otherwise the url
reference picks whatever is last and results in weird styles
@ItsANameToo updated with a more unique id |
Summary
Related to https://app.clickup.com/t/861mruhvw
Checklist