Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config parameter for core-database to allow using real counts #3711

Closed
air1one opened this issue May 19, 2020 · 4 comments
Closed

Add config parameter for core-database to allow using real counts #3711

air1one opened this issue May 19, 2020 · 4 comments
Assignees

Comments

@air1one
Copy link
Contributor

air1one commented May 19, 2020

In core-database package add a config parameter to use real counts instead of estimates (default it to not using real counts in defaults.ts)

@faustbrian
Copy link
Contributor

This is quite risky and could easily be abused on lower-spec nodes because the estimates were implemented specifically to let the node maintainer decide based on their specs if they can handle them or not. If we allow them to be disabled via query parameters there is no point in having them at all.

@air1one
Copy link
Contributor Author

air1one commented May 19, 2020

Ok so after talking about it, the config parameter will be enough @rainydio no need for URL param, the node maintainer decides either to allow real counts for every request or estimates for every request.

@air1one air1one changed the title Add config parameter for API to allow using real counts through url parameter Add config parameter for core-api to allow using real counts May 19, 2020
@faustbrian
Copy link
Contributor

1e185ea

This simply needs to be ported to 3.0 by using the estimateTotalCount configuration from the core-database package.

@air1one air1one changed the title Add config parameter for core-api to allow using real counts Add config parameter for core-database to allow using real counts May 19, 2020
@rainydio
Copy link
Contributor

rainydio commented Jun 1, 2020

Implemented in #3725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants