Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for VS2019 #119

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@ciband
Copy link
Collaborator

commented Aug 30, 2019

Added support for VS2019 and maintained support for VS2017.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
chore: Add support for VS2019
Added support for VS2019 and maintained support for VS2017.
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ciband

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 30, 2019

VS2019 targets work under VS2019 IDE. VS2017 targets work under VS2017 IDE and VS2019 IDE. The VS2019 targets to not work, which is expected. They give reasonable diagnostics as to why they do not work.

This PR is ready for review.

@ciband

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 1, 2019

Appveyor build failure is due to no appveyor config file. I will be submitting a PR to fix this. This is not related to this change. The JSON file is just for IDE config.

@sleepdefic1t sleepdefic1t self-requested a review Sep 1, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 0cb71f0 into ArkEcosystem:develop Sep 3, 2019

7 of 8 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: build-arduino-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-2 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-3 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.