Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge master => develop #148

Merged
merged 9 commits into from
Oct 18, 2019
Merged

chore: merge master => develop #148

merged 9 commits into from
Oct 18, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Summary

Master includes several changes needed to properly run CI on develop (e.g. coverage workflow, codeclimate checks).

Checklist

  • Ready to be merged

faustbrian and others added 9 commits July 22, 2019 08:09
### Added
-   added Blockchain API endpoint (#104)

### Changed
-   improved API query usage to accept strings (#114)
-   improved class members and test coverage (#93)
-   improved formatting and maintainability (#92)
-   dropped Hunter Package Manager in favor of git submodules in OS builds (#90)
-   updated ArduinoJson 5.13.2 >> 6.10.1, usage patterns, and documentation/examples (#87)
-   moved external libraries out of source tree (#140)

### Fixed
-   fixed typos in Arduino examples (#86)
-   changed to "statusCode" '422' to test API Post response for empty Transactions objects (#85)
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Oct 16, 2019
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #148 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #148   +/-   ##
========================================
  Coverage    79.47%   79.47%           
========================================
  Files           26       26           
  Lines          497      497           
========================================
  Hits           395      395           
  Misses         102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2394fb9...abcbadc. Read the comment docs.

@sleepdefic1t
Copy link
Contributor Author

@faustbrian good to go 👍

@faustbrian faustbrian merged commit 7a0d7f9 into develop Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants