-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 2.6 endpoints #159
feat: add 2.6 endpoints #159
Conversation
* test: Fix EPS32 test builds ESP32 test builds were not passing and the tests themselves were not being compiled into the firmware binary. Added missing ignore filters to ignore desktop libraries for building PIO and desktop targets in the same source tree. * test: Fix ESP8266 tests Split up and re-enabled ESP8266 tests. API tests required further splitting due to large amounts of strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing declaration.
api/wallets/wallets.h
ln#50
std::string top(const char* const query) override;
std::string locks(const char *const identifier, const char* const query) override; // <--
std::string transactions(const char *const identifier, const char* const query) override;
Typo
test/api/paths.cpp
ln# 301
const auto locks = paths::Wallets::locks(
testHost, "DNv1iScT2DJBWzpJd1AFYkTx1xkAZ9XVJk", "?limit=1&page=5");
ASSERT_STREQ(
"0.0.0.0:4003/api/wallets/DNv1iScT2DJBWzpJd1AFYkTx1xkAZ9XVJk/locks?limit=1&page=5",
locks.c_str()); // <-- (transactions.c_str() → locks.c_str())
There's more, but these ones popped up in the mean time.
@dated Looks like Paths::locks in |
Thanks! I'll have a proper look asap |
Are those API POST bodys correct? I was only able to use these with Postman.
|
I'll see what I can find in the core repository, there are docs available yet for the new endpoints 😕 |
Indeed the |
nice! 😎 Just to do a sanity check on the businesses endpoints, The |
I'll do some tests and get back to you! |
The schema validation will cast the given parameters to the types defined in the schema. |
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
Summary
Adds the following API endpoints
GET
bridgechains
bridgechains/{id}
businesses
businesses/{id}
businesses/{id}/bridgechains
wallets/{id}/locks
locks
locks/{id}
POST
businesses/search
bridgechains/search
locks/search
locks/unlocked
Checklist