[WIP]fix(http): arduino get/post #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes invalid URL construction and simplifies how the HTTP Get/Post calls are handled in Arduino environments. It also fixes a typo in the ESP32 Demo Sketch.
Current implementation seems to work fine on everything except for ESP8266. This commit drops raw pointer usage in favor of strings, allowing ESP8266 to make stable API calls.
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
ghost
added
Complexity: Medium
…defic1t/cpp-client into fix(http)/arduino-get-post
* test: Fix EPS32 test builds ESP32 test builds were not passing and the tests themselves were not being compiled into the firmware binary. Added missing ignore filters to ignore desktop libraries for building PIO and desktop targets in the same source tree. * test: Fix ESP8266 tests Split up and re-enabled ESP8266 tests. API tests required further splitting due to large amounts of strings.
sleepdefic1t
changed the title
|
[Do Not Merge] This will need additional updates after #159 is merged. |
* feat: wallets locks endpoint * refactor: add missing test * feat: add businesses endpoints * feat: add bridgechains endpoints * feat: add locks endpoints * fix: header files * fix: typo * fix: typo * Enable esp8266 tests (#158) * test: Fix EPS32 test builds ESP32 test builds were not passing and the tests themselves were not being compiled into the firmware binary. Added missing ignore filters to ignore desktop libraries for building PIO and desktop targets in the same source tree. * test: Fix ESP8266 tests Split up and re-enabled ESP8266 tests. API tests required further splitting due to large amounts of strings. * fix: various typos and missing declarations * fix: add new files to arduino * fix: typo * refactor: adjust unlocked post params * refactor: adjust mock signature
This PR fixes invalid URL construction and simplifies how the HTTP Get/Post calls are handled in Arduino environments. It also fixes a typo in the ESP32 Demo Sketch.
Current implementation seems to work fine on everything except for ESP8266. This commit drops raw pointer usage in favor of strings, allowing ESP8266 to make stable API calls.
…defic1t/cpp-client into fix(http)/arduino-get-post
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes invalid URL construction and simplifies how the HTTP Get/Post calls are handled in Arduino environments.
This PR also does the following:
Checklist