Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Price doesn't seem to update #398

Closed
rpolve opened this issue Nov 14, 2017 · 2 comments
Closed

Price doesn't seem to update #398

rpolve opened this issue Nov 14, 2017 · 2 comments
Assignees
@j-a-m-l

Comments

@rpolve
Copy link

rpolve commented Nov 14, 2017 •
edited

Price doesn't seem to update on my desktop wallet, whatever the currency, nor am I able to force it to do so.

Arkclient 1.4.1
Ubuntu 16.04.3 LTS
@j-a-m-l j-a-m-l self-assigned this Nov 14, 2017
@j-a-m-l
Copy link
Contributor

j-a-m-l commented Nov 14, 2017

This is related to #221.

@ckhatri
Copy link
Contributor

ckhatri commented Nov 14, 2017 •
edited

Looks like v5 of the api (which we use) was deprecated October 31st.
https://www.reddit.com/r/coinmarketcapjson/comments/6wrv72/new_version_v8_is_stable/

Currently whenever I try to query for any /ticker for v8 there's an internal server error at the moment. So you can't get the specific information about any ticker right now. Not sure if this will be fixed anytime soon, reached out to the dev.

If we use the official api https://api.coinmarketcap.com/v1/ticker/ark/ it only gives prices in btc/usd. But we could make multiple requests to get all the currencies using the convert parameter (which only takes one currency), which seems redundant.

Or maybe use another api for exchange rates: http://fixer.io/ and combine that with the official api

What do y'all think?

edit: implemented the last idea in #400

@ckhatri ckhatri mentioned this issue Nov 14, 2017
Closed
@alexbarnsley alexbarnsley mentioned this issue Nov 17, 2017
Merged
alexbarnsley pushed a commit that referenced this issue Dec 3, 2018
@j-a-m-l @faustbrian
Refactor modal transaction footer (#398)
8325b1f 
* refactor: allow customizing the modal footer

* refactor: allow adding a footer to transaction modals

* improvement: allow customizing the modal style

* improvement: limit the maximum width of transaction modals
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@j-a-m-l j-a-m-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@j-a-m-l @ckhatri @rpolve