-
Notifications
You must be signed in to change notification settings - Fork 192
feat(plugins): allow adding custom themes #1194
Conversation
Codecov Report
@@ Coverage Diff @@
## next #1194 +/- ##
==========================================
- Coverage 39.29% 38.88% -0.41%
==========================================
Files 224 224
Lines 5935 6000 +65
Branches 1184 1200 +16
==========================================
+ Hits 2332 2333 +1
- Misses 3405 3460 +55
- Partials 198 207 +9
Continue to review full report at Codecov.
|
@j-a-m-l do you have an example plugin I can test this with? |
I like this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful theme 🌮!
- It can overwrite the built-in themes (light/dark) without the user editing the profile;
- When the plugin is removed or disabled the wallet does not apply any default theme.
@luciorubeens I've made several changes. About overwriting user styles, it can happen everywhere, as the security testing plugin demonstrated. We don't have a good solution for that. At most we could try to remove rules before/after injecting the CSS, but it wouldn't matter, since users could include them on HTML or using new tricks. |
Proposed changes
This PR includes a way to load and select new UI themes.
This PR depends on #1191 to deal with permissions
Types of changes
Checklist