This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
merge develop to master #1434
Merged
merge develop to master #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(deps): bump mixin-deep from 1.3.1 to 1.3.2 Co-authored-by: null <49699333+dependabot[bot]@users.noreply.github.com>
* chore: update peers package * fix: cater for new breaking changes * fix: add peers to got webpack whitelist * fix: add version to custom network form * test: fix failing
* fix: development mode message in production * fix: remove error log * chore: add script to build win x64
* fix: properly format crypto currencies * chore: typo `precissely` -> `precisely` * test: remove `only`
…gate to transactions tab always (#1143) * fix: close transaction show when clicking on and address and navigate to transactions tab always * fix: close vote modal when clicking on and address and navigate to transactions tab always * fix: hide the tooltip when clicking on a wallet address
* chore(deps): update all electron dependencies * chore: resolve conflicts
* refactor: remove dot from extensions * feat: add electron_readFile mixin * refactor: also return filePath from electron_readFile mixin * feat: basic structure for loading a transaction * refactor: change error handling and populate form * refactor: check if properties exist * refactor: improved error handling and validation * chore: wording * chore: wording * fix: allowClose prop requiredness * chore: replace icon * test: add TransactionFormTransfer tests * chore: remove debugger statement * style: update imports * chore: restore shalloMount import
* feat: use websockets in plugins * test: plugin websocket * fix: websocket readystate * refactor: improve inline de-structuring speed * chore: update yarn.lock
alexbarnsley
requested review from
faustbrian,
ItsANameToo and
luciorubeens
as code owners
|
Your pull request doesn't follow our contribution guidelines. Please review and correct it. |
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
==========================================
+ Coverage 39.94% 40.72% +0.78%
==========================================
Files 236 237 +1
Lines 6452 6536 +84
Branches 1278 1300 +22
==========================================
+ Hits 2577 2662 +85
+ Misses 3637 3631 -6
- Partials 238 243 +5
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Sep 4, 2019
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.