Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: hidden delegate dropdown on search #1552

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

alexbarnsley
Copy link
Member

Overflow of ModalWindow is now hidden. This causes issues with anything inside the component, in this case, a dropdown menu. The fix only applies to the Delegate search modal.

Resolves #1459

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Nov 21, 2019
@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #1552 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #1552   +/-   ##
=======================================
  Coverage     45.7%   45.7%           
=======================================
  Files          274     274           
  Lines         6853    6853           
  Branches      1343    1343           
=======================================
  Hits          3132    3132           
  Misses        3559    3559           
  Partials       162     162
Impacted Files Coverage Δ
...enderer/components/Wallet/WalletSelectDelegate.vue 37.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f868e57...8bb5ca3. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 97adaed into develop Dec 5, 2019
@ghost ghost deleted the fix/delegate-dropdown-hidden branch December 5, 2019 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search delegate popup
2 participants