Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

test: plugin manager unit tests #1583

Merged
merged 70 commits into from
Feb 26, 2020
Merged

test: plugin manager unit tests #1583

merged 70 commits into from
Feb 26, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Dec 11, 2019

Summary

Adds unit tests for plugin manager related parts, mainly the plugin store module.

image

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements. Status: In Progress The issue or pull request is being worked on. labels Dec 11, 2019
@alexbarnsley
Copy link
Member

👀

@dated dated marked this pull request as ready for review February 24, 2020 21:16
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Feb 24, 2020
@dated
Copy link
Contributor Author

dated commented Feb 24, 2020

@alexbarnsley 👀

@alexbarnsley
Copy link
Member

It's a good start :trollface:

@dated
Copy link
Contributor Author

dated commented Feb 25, 2020

:danstop:

@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Feb 26, 2020
@ghost
Copy link

ghost commented Feb 26, 2020

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@boldninja
Copy link
Member

:noah:

@alexbarnsley alexbarnsley merged commit b2832b2 into ArkEcosystem:develop Feb 26, 2020
@ghost
Copy link

ghost commented Feb 26, 2020

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 26, 2020
@dated dated deleted the tests/plugin-manager branch February 26, 2020 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Status: Member Approved The pull request has been approved by a member. Test: Unit The issue or pull request is related to unit tests for testing individual elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants