Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: limit delegate query to 100 & dynamic per page options #1625

Merged
merged 4 commits into from
Jan 29, 2020
Merged

fix: limit delegate query to 100 & dynamic per page options #1625

merged 4 commits into from
Jan 29, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Jan 25, 2020 •
edited
Loading

Summary

Limits the delegate query to 100 and dynamically calculates the per page options.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Jan 25, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jan 25, 2020
@alexbarnsley
Copy link
Member

Wen #1583? :trollface:

@alexbarnsley
Copy link
Member

Could you add tests for this. If the file doesn't exist, just add the basic mount stuff and tests for what you've added please

@alexbarnsley alexbarnsley added the Status: Needs Testcase The issue or pull request relates to a feature that needs test coverage. label Jan 25, 2020
@ghost
Copy link

ghost commented Jan 25, 2020

Your pull request doesn't have a test case, which is a requirement for it to be merged. Please provide it and one of the developers will review it before merging.

@ghost ghost mentioned this pull request Jan 26, 2020
Closed
@ghost
Copy link

ghost commented Jan 29, 2020

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Jan 29, 2020
@alexbarnsley alexbarnsley added Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. and removed Status: Needs Testcase The issue or pull request relates to a feature that needs test coverage. labels Jan 29, 2020
@alexbarnsley alexbarnsley merged commit f2f5fbe into ArkEcosystem:develop Jan 29, 2020
@ghost
Copy link

ghost commented Jan 29, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the fix/delegate-limit branch January 29, 2020 12:17
@ghost ghost mentioned this pull request Feb 2, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexbarnsley alexbarnsley alexbarnsley approved these changes

@faustbrian faustbrian Awaiting requested review from faustbrian

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@luciorubeens luciorubeens Awaiting requested review from luciorubeens

Assignees
No one assigned
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Member Approved The pull request has been approved by a member. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dated @alexbarnsley