Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: set currentPage / currentPerPage only if different from current value #1612

Merged
merged 11 commits into from
Feb 24, 2020
Merged

refactor: set currentPage / currentPerPage only if different from current value #1612

merged 11 commits into from
Feb 24, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Jan 20, 2020

Summary

Follow up to #1611.

When the per page count is changed vue-good-table emits the on-per-page-change event twice, which in turn result in two api calls to be made calls to the loadTransactions method. By checking if the current value is equal to the emitted value first only one request will be done the above method will be called only once.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Jan 20, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jan 20, 2020
@dav1app
Copy link
Contributor

dav1app commented Jan 20, 2020

This works better.

@dated
Copy link
Contributor Author

dated commented Jan 21, 2020

Relevant issue in the vue-good-table repo: xaksis/vue-good-table#654

@dated dated mentioned this pull request Feb 20, 2020
3 tasks
@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Feb 24, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@alexbarnsley alexbarnsley merged commit f6b4126 into ArkEcosystem:develop Feb 24, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@dated dated deleted the refactor/table-events branch February 24, 2020 21:14
@alexbarnsley alexbarnsley added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Feb 24, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Member Approved The pull request has been approved by a member. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants