Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: translate the keypath values of the background and avatars modal #1665

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Feb 11, 2020

Summary

Fixes #1664.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Feb 11, 2020
Copy link
Contributor

@luciorubeens luciorubeens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to mock this strings_snakeCase method directly in the SelectionBackground.spec.js file or in the setup: https://github.com/ArkEcosystem/desktop-wallet/blob/develop/__tests__/unit/__utils__/setup.js.

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #1665 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1665   +/-   ##
========================================
  Coverage    62.95%   62.95%           
========================================
  Files          135      135           
  Lines         3663     3663           
  Branches       767      767           
========================================
  Hits          2306     2306           
  Misses        1134     1134           
  Partials       223      223
Impacted Files Coverage Δ
...erer/components/Selection/mixin-selection-image.js 68.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bda0e3a...7bc9c69. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 44f0769 into develop Feb 11, 2020
@ghost ghost deleted the fix/translate-keypath-mixin branch February 11, 2020 23:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cannot translate the keypath values ​​of the background and avatars selections
3 participants