Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add Badge component #2085

Merged
merged 4 commits into from
Jun 11, 2020
Merged

feat: add Badge component #2085

merged 4 commits into from
Jun 11, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jun 10, 2020

Summary

General purpose badge component to be used along with avatars, coin icons et. all

  • requires a parent with relative positon.
  • position, size, shape, colors, controlled by regular (tailwind) css classes (e.g -right-2 -bottom-2).
  • icon="name" prop to internally render an Icon component.
  • accepts slot for custom content.

Preview:
2020-06-10-142343_278x168_scrot
2020-06-10-142350_424x94_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner June 10, 2020 11:25
@ghost ghost added the Complexity: High More than 256 lines changed. label Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #2085 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.0-react     #2085   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files             45        55   +10     
  Lines            298       381   +83     
  Branches          49        66   +17     
===========================================
+ Hits             298       381   +83     
Impacted Files Coverage Δ
src/app/components/Alert/Alert.tsx 100.00% <ø> (ø)
src/app/components/Dropdown/Dropdown.tsx 100.00% <ø> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <ø> (ø)
src/app/components/Select/Select.tsx 100.00% <ø> (ø)
...app/components/SideBar/SideBarItem/SideBarItem.tsx 100.00% <ø> (ø)
...ings/pages/Settings/available-settings/General.tsx 100.00% <ø> (ø)
...ins/wallets/components/SignMessage/SignMessage.tsx 100.00% <ø> (ø)
...omains/wallets/pages/ImportWallet/ImportWallet.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1c8fd...b28ed61. Read the comment docs.

@faustbrian faustbrian changed the title Feat/component badge feat: add Badge component Jun 10, 2020
@goga-m
Copy link
Contributor Author

goga-m commented Jun 10, 2020

I am refactoring this branch to remove conflicts and update with svg-usage

@goga-m goga-m marked this pull request as draft June 10, 2020 18:43
@goga-m goga-m marked this pull request as ready for review June 10, 2020 19:00
@goga-m goga-m mentioned this pull request Jun 10, 2020
3 tasks
@faustbrian faustbrian merged commit f53b4b1 into 3.0-react Jun 11, 2020
@ghost ghost deleted the feat/component-badge branch June 11, 2020 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants