Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add SelectNetwork component #2092

Merged
merged 4 commits into from
Jun 11, 2020
Merged

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jun 10, 2020

Summary

Depends on #2085

Select network list

  • clickable network icons to act as radio buttons for selecting networks
  • emits onChange(changedNetwork, updatedNetworkList)
  • emits onViewAll when All link is clicked

Usage:

	const networks = [
		{
			name: "Ark",
			isSelected: true,
		},
		{
			name: "Eth",
			isSelected: true,
		},
		{
			name: "Btc",
			isSelected: false,
		},
	];
	return (
		<div>
			<SelectNetwork
				networks={networks}
				onChange={(selectedNetwork, updatedNetworkList) => ()}
				onViewAll={() => alert("View all networks")}
			></SelectNetwork>
		</div>
	);

Preview:
2020-06-10-231326_329x96_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner June 10, 2020 20:15
@ghost ghost added the Complexity: High More than 256 lines changed. label Jun 10, 2020
@goga-m goga-m changed the title Feat/component select network feat: component select network Jun 10, 2020
@goga-m goga-m changed the title feat: component select network feat: add component selectNetwork Jun 10, 2020
@goga-m goga-m mentioned this pull request Jun 10, 2020
3 tasks
@faustbrian faustbrian changed the title feat: add component selectNetwork feat: add SelectNetwork component Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #2092 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2092    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             45        61    +16     
  Lines            298       438   +140     
  Branches          49        73    +24     
============================================
+ Hits             298       438   +140     
Impacted Files Coverage Δ
src/app/components/Alert/Alert.tsx 100.00% <ø> (ø)
src/app/components/Dropdown/Dropdown.tsx 100.00% <ø> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <ø> (ø)
src/app/components/Select/Select.tsx 100.00% <ø> (ø)
...app/components/SideBar/SideBarItem/SideBarItem.tsx 100.00% <ø> (ø)
...ings/pages/Settings/available-settings/General.tsx 100.00% <ø> (ø)
...s/wallets/components/MnemonicList/MnemonicList.tsx 100.00% <ø> (ø)
...ins/wallets/components/SignMessage/SignMessage.tsx 100.00% <ø> (ø)
...omains/wallets/pages/ImportWallet/ImportWallet.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53b4b1...e9cb58e. Read the comment docs.

@faustbrian faustbrian merged commit 53d34a5 into 3.0-react Jun 11, 2020
@ghost ghost deleted the feat/component-select-network branch June 11, 2020 01:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants