Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add plugin details page #2250

Merged
merged 29 commits into from
Jun 25, 2020
Merged

feat: add plugin details page #2250

merged 29 commits into from
Jun 25, 2020

Conversation

clucasalcantara
Copy link
Contributor

@clucasalcantara clucasalcantara commented Jun 24, 2020 •
edited
Loading

Summary

Depends on #2249 and still have some work to do

  • Adds plugin details page

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Jun 24, 2020
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Status: In Progress The issue or pull request is being worked on. labels Jun 24, 2020
@clucasalcantara clucasalcantara changed the title Feat/add plugin details feat: add plugin details page Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020 •
edited
Loading

Codecov Report

Merging #2250 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2250     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       186    +162     
  Lines            142      1619   +1477     
  Branches          18       281    +263     
=============================================
+ Hits             142      1619   +1477
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1a190...24092ed. Read the comment docs.

@faustbrian
Copy link
Contributor

@clucasalcantara builds fail

clucasalcantara and others added 18 commits June 25, 2020 08:24
@clucasalcantara
feat(review-box): add stars counters
e9c628b
@clucasalcantara
feat(plugin-details): add review box component
8c9a3dd
@clucasalcantara
feat: wip add comments pagination component
db7a2e7
@clucasalcantara
feat(comments): add reply component
f09ae37
@clucasalcantara
feat(utils): add date difference utility
d0f2015
@clucasalcantara
feat(comments): add reply with temp dangerous innerHTML
0896530
@clucasalcantara
chore(debug): remove console logs
84666a0
@clucasalcantara
tests(pagination): add pagination specs
187ba71
@clucasalcantara
tests: add specs
5f350ed
@clucasalcantara
tests: rename from spec to test
1cefd36
@clucasalcantara
refactor: move comments out of reviewbox
c49daea
@clucasalcantara
feat: wip add plugin details page
8a2e016
@clucasalcantara
fix: undo accidental change to dropdown
97c3ece
@clucasalcantara
feat: update plugin header component
fae90af
@clucasalcantara
feat(assets): add update icon
148a43f
@clucasalcantara
tests: update snapshots
7459c2d
@boldninja @clucasalcantara
chore: optimize 2 SVG(s)
5444470 
Optimized SVG(s):
- src/app/assets/svg/reply-arrow.svg
- src/app/assets/svg/update.svg
@boldninja @clucasalcantara
style: resolve style guide violations
16df5c5
boldninja and others added 2 commits June 25, 2020 15:13
@boldninja
chore: optimize 1 SVG(s)
762b15a 
Optimized SVG(s):
- src/app/assets/svg/reply-arrow.svg
@boldninja @actions-user
style: resolve style guide violations
75ff9fa
@alexbarnsley alexbarnsley mentioned this pull request Jun 25, 2020
Merged
3 tasks
@clucasalcantara clucasalcantara marked this pull request as ready for review June 25, 2020 14:37
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jun 25, 2020
@faustbrian faustbrian merged commit 08d44a6 into 3.0-react Jun 25, 2020
@ghost ghost deleted the feat/add-plugin-details branch June 25, 2020 14:53
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jun 25, 2020
@ghost ghost mentioned this pull request Jun 28, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian faustbrian approved these changes

Assignees

@clucasalcantara clucasalcantara

Labels
Complexity: Undetermined Needs specialized, in-depth review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clucasalcantara @faustbrian @boldninja