Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add comments section #2249

Merged
merged 26 commits into from
Jun 25, 2020
Merged

feat: add comments section #2249

merged 26 commits into from
Jun 25, 2020

Conversation

clucasalcantara
Copy link
Contributor

Summary

  • Add comments section to be used in plugin details page

UI Preview

Screen Shot 2020-06-24 at 09 06 25

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Jun 24, 2020
@ghost ghost added the Complexity: Undetermined Needs specialized, in-depth review. label Jun 24, 2020
@clucasalcantara clucasalcantara changed the title Feat/add comments section feat(plugin-details): add comments section Jun 24, 2020
boldninja and others added 2 commits June 24, 2020 14:09
Optimized SVG(s):
- src/app/assets/svg/reply-arrow.svg
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #2249 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2249     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       183    +159     
  Lines            142      1575   +1433     
  Branches          18       272    +254     
=============================================
+ Hits             142      1575   +1433     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 210 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37669dc...551d459. Read the comment docs.

@faustbrian
Copy link
Contributor

@clucasalcantara build fails on all 3 systems https://github.com/ArkEcosystem/desktop-wallet/pull/2249/checks?check_run_id=803292757

@faustbrian faustbrian changed the title feat(plugin-details): add comments section feat: add comments section Jun 25, 2020
@faustbrian faustbrian merged commit 1682c7c into 3.0-react Jun 25, 2020
@ghost ghost deleted the feat/add-comments-section branch June 25, 2020 02:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants