Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: ui tweaks plugin details #2299

Merged
merged 15 commits into from
Jul 1, 2020
Merged

fix: ui tweaks plugin details #2299

merged 15 commits into from
Jul 1, 2020

Conversation

clucasalcantara
Copy link
Contributor

Summary

  • Adjust report icon
  • Add verified icon to author
  • Add missing start to rating on plugin specs
  • Adjust spacing on the reviews section
  • Adjust font size to reviews title

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Jun 30, 2020
@ghost ghost added Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jun 30, 2020
@boldninja
chore: optimize 2 SVG(s)
a1a92fa 
Optimized SVG(s):
- src/app/assets/svg/report.svg
- src/app/assets/svg/verified.svg
@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited

Codecov Report

Merging #2299 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2299     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       217    +193     
  Lines            142      2172   +2030     
  Branches          18       414    +396     
=============================================
+ Hits             142      2172   +2030
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
... and 243 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0029254...11bc0e7. Read the comment docs.

@clucasalcantara clucasalcantara marked this pull request as draft June 30, 2020 12:39
@clucasalcantara clucasalcantara marked this pull request as ready for review June 30, 2020 12:45
@faustbrian faustbrian merged commit cc268c2 into 3.0-react Jul 1, 2020
@faustbrian faustbrian deleted the fix/ui-tweaks-plugin-details branch July 1, 2020 15:33
@ghost ghost mentioned this pull request Jul 5, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

Assignees

@clucasalcantara clucasalcantara

Labels
Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clucasalcantara @faustbrian @boldninja