Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore: fix card handleclick error on Card #2393

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 7, 2020

Summary

Fix handleClick is not a function error on click event in Card component when handleClick callback is not provided.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 7, 2020 11:47
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jul 7, 2020
@goga-m goga-m changed the title fix: card handleclick error on Card chore: fix card handleclick error on Card Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #2393 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2393     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       226    +202     
  Lines            142      2288   +2146     
  Branches          18       438    +420     
=============================================
+ Hits             142      2288   +2146     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
... and 250 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a2800...302b40d. Read the comment docs.

@faustbrian faustbrian merged commit 7ea65ec into 3.0-react Jul 7, 2020
@ghost ghost deleted the fix/card-handleclick-error branch July 7, 2020 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants