Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: adjust avatar size and margins in transaction components #2422

Merged
merged 3 commits into from
Jul 10, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Jul 9, 2020

Summary

Fixes the size and vertical alignment of the avatar in the Registration, ResignRegistration, TransactionDetail, TransactionSend, TransactionSuccessful, VoteList components. Also fixes the top margin that is added even when there is no label.

image

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner July 9, 2020 18:58
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #2422 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2422     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       251    +227     
  Lines            142      2496   +2354     
  Branches          18       468    +450     
=============================================
+ Hits             142      2496   +2354     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293d29a...ae23bfc. Read the comment docs.

@dated dated changed the title fix: adjust avatar size and margins in TransactionSuccessful component fix: adjust avatar size and margins in transaction components Jul 9, 2020
@faustbrian faustbrian merged commit 12927dd into 3.0-react Jul 10, 2020
@ghost ghost deleted the fix/tx-successful branch July 10, 2020 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants