Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: remove readonly and add disabled property #2442

Merged
merged 2 commits into from
Jul 11, 2020

Conversation

brenopolanski
Copy link
Contributor

Summary

The readonly is not supported for checkbox and radio.

The readonly attribute is supported by text, search, url, tel, email, password, date, month, week, time, datetime-local, and number types and the <textarea> form control elements.

Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/readonly

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 10, 2020
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #2442 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2442     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       258    +234     
  Lines            142      2537   +2395     
  Branches          18       469    +451     
=============================================
+ Hits             142      2537   +2395     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 282 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a6282...d056e7a. Read the comment docs.

@faustbrian faustbrian merged commit 9456be8 into 3.0-react Jul 11, 2020
@ghost ghost deleted the refactor/card-control-tweaks branch July 11, 2020 02:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants