Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: implement profile creating #2461

Merged
merged 8 commits into from
Jul 14, 2020
Merged

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Jul 14, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Jul 14, 2020
@alexbarnsley alexbarnsley marked this pull request as ready for review July 14, 2020 12:25
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jul 14, 2020
@alexbarnsley
Copy link
Member Author

@faustbrian can you check and make sure I've understood the SDK side of it please. I also wasn't sure how to access the env/profiles within the second test to make sure it was still created

@alexbarnsley
Copy link
Member Author

alexbarnsley commented Jul 14, 2020

the merge has broken stuff. i'll need to fix it tonight

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #2461 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2461     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       265    +241     
  Lines            142      2591   +2449     
  Branches          18       477    +459     
=============================================
+ Hits             142      2591   +2449     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 289 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8b13d...98f4522. Read the comment docs.

@faustbrian
Copy link
Contributor

@faustbrian can you check and make sure I've understood the SDK side of it please. I also wasn't sure how to access the env/profiles within the second test to make sure it was still created

What test do you mean, I assume https://github.com/ArkEcosystem/desktop-wallet/pull/2461/files#diff-b0f51b717f96d11aff34382b99e06356R80?

@alexbarnsley
Copy link
Member Author

@faustbrian that's redundant now if I make the callback required

@alexbarnsley
Copy link
Member Author

@faustbrian that callback is now required

@faustbrian faustbrian changed the title feat: implement profile storage feat: implement profile creating Jul 14, 2020
@faustbrian faustbrian merged commit f5c057e into 3.0-react Jul 14, 2020
@ghost ghost deleted the feat/implement-profile-storage branch July 14, 2020 16:36
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants