Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore: input ui fix #2484

Merged
merged 14 commits into from
Jul 16, 2020
Merged

chore: input ui fix #2484

merged 14 commits into from
Jul 16, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 15, 2020

Summary

Fix Input focused border.

  • Use shadow on focused input instead of border-2.
  • Prevent adding focus shadow if input has class shadow-none
  • Fix SelectNetwork border/shadow
  • Fix SelectDropdown border/shadow
  • Remove unnecessary styled overrides in NewsOptions and HeaderSearchBar (using shadow-none)

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Status: In Progress The issue or pull request is being worked on. labels Jul 15, 2020
@goga-m goga-m changed the title Chore/input ui fix chore: input ui fix Jul 15, 2020
@goga-m goga-m marked this pull request as ready for review July 16, 2020 08:46
@goga-m goga-m requested a review from faustbrian as a code owner July 16, 2020 08:46
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jul 16, 2020
@ArkEcosystem ArkEcosystem deleted a comment from codecov bot Jul 16, 2020
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #2484 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2484     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       265    +241     
  Lines            142      2651   +2509     
  Branches          18       488    +470     
=============================================
+ Hits             142      2651   +2509     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 288 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed5a853...1bc6381. Read the comment docs.

@faustbrian faustbrian merged commit 86f9f62 into 3.0-react Jul 16, 2020
@ghost ghost deleted the chore/input-ui-fix branch July 16, 2020 10:02
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants