This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
refactor: add and make use of i18n translations #2518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Undetermined
Needs specialized, in-depth review.
Type: Refactor
The pull request improves or enhances an existing implementation.
labels
Jul 22, 2020
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2518 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 266 +242
Lines 142 2808 +2666
Branches 18 507 +489
=============================================
+ Hits 142 2808 +2666
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@dated build fails |
faustbrian
approved these changes
Jul 23, 2020
faustbrian
changed the title
refactor: more i18n
refactor: add and make use of i18n translations
Jul 23, 2020
ghost
deleted the
refactor/i18n
branch
July 23, 2020 05:02
ghost
mentioned this pull request
Jul 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Undetermined
Needs specialized, in-depth review.
Type: Refactor
The pull request improves or enhances an existing implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds proper i18n almost everywhere. Some components in the transaction domain have not been changed yet due to pending redesigns. It will be picked up again once the designs have been finalised.
Checklist