Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: add and make use of i18n translations #2518

Merged
merged 29 commits into from
Jul 23, 2020
Merged

Conversation

dated
Copy link
Contributor

@dated dated commented Jul 22, 2020

Summary

Adds proper i18n almost everywhere. Some components in the transaction domain have not been changed yet due to pending redesigns. It will be picked up again once the designs have been finalised.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner July 22, 2020 21:50
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation. labels Jul 22, 2020
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #2518 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2518     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       266    +242     
  Lines            142      2808   +2666     
  Branches          18       507    +489     
=============================================
+ Hits             142      2808   +2666     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 287 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78bab92...34a245c. Read the comment docs.

@faustbrian
Copy link
Contributor

@dated build fails

@faustbrian faustbrian changed the title refactor: more i18n refactor: add and make use of i18n translations Jul 23, 2020
@faustbrian faustbrian merged commit 57a9811 into 3.0-react Jul 23, 2020
@ghost ghost deleted the refactor/i18n branch July 23, 2020 05:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants