This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: High
More than 256 lines changed.
Type: Feature
The issue is a request for new functionality.
labels
Jul 23, 2020
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2520 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 253 +229
Lines 142 2766 +2624
Branches 18 495 +477
=============================================
+ Hits 142 2766 +2624
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@brenopolanski this needs E2E tests |
@brenopolanski failing e2e tests after merging, related to this PR |
ghost
mentioned this pull request
Jul 26, 2020
@brenopolanski conflicts and still failing e2e |
luciorubeens
force-pushed
the
feat/implement-message-signing
branch
from
July 28, 2020 11:54
e108dde
to
d0d4376
Compare
goga-m
reviewed
Jul 28, 2020
src/domains/wallet/pages/WalletDetails/__snapshots__/WalletDetails.test.tsx.snap
Outdated
Show resolved
Hide resolved
ghost
deleted the
feat/implement-message-signing
branch
July 28, 2020 12:36
ghost
mentioned this pull request
Aug 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: High
More than 256 lines changed.
Type: Feature
The issue is a request for new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Task: https://trello.com/c/e8pcMUhN/108-implement-message-signing
Checklist