Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: implement message signing #2520

Merged
merged 22 commits into from
Jul 28, 2020
Merged

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Jul 23, 2020

Summary

Task: https://trello.com/c/e8pcMUhN/108-implement-message-signing

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Jul 23, 2020
@brenopolanski brenopolanski marked this pull request as draft July 24, 2020 12:07
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #2520 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2520     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       253    +229     
  Lines            142      2766   +2624     
  Branches          18       495    +477     
=============================================
+ Hits             142      2766   +2624     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 274 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6426b...acd2d1a. Read the comment docs.

@brenopolanski brenopolanski marked this pull request as ready for review July 24, 2020 13:01
@faustbrian
Copy link
Contributor

@brenopolanski this needs E2E tests

@faustbrian
Copy link
Contributor

@brenopolanski failing e2e tests after merging, related to this PR

@faustbrian
Copy link
Contributor

@brenopolanski conflicts and still failing e2e

@luciorubeens luciorubeens force-pushed the feat/implement-message-signing branch from e108dde to d0d4376 Compare July 28, 2020 11:54
@faustbrian faustbrian merged commit 8bbd088 into 3.0-react Jul 28, 2020
@ghost ghost deleted the feat/implement-message-signing branch July 28, 2020 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants