-
Notifications
You must be signed in to change notification settings - Fork 193
refactor: sdk wallet integration into components #2532
refactor: sdk wallet integration into components #2532
Conversation
…/desktop-wallet into refactor/pass-in-sdk-wallet
…/desktop-wallet into refactor/pass-in-sdk-wallet
This PR is pretty much ready functionality-wise (waiting on #2570 to properly test though). What isn't ready is the memory limit where tests are now failing, I think because of the extra tests/additional functionality. I'm kind of stuck now, probably because of how large I made this PR I was debugging and noticed that if I invalidate the jest.setup.js:
To run:
I think it could be this line in @clucasalcantara @luciorubeens @goga-m @brenopolanski @dated if anyone has any ideas, that would be great! I think I'm just clutching at straws now. TL;DR I'm stuck |
@faustbrian I'm aware of the conflicts - sorting them along with fixing tests based on changes that were made before pushing. |
@alexbarnsley tried the case with invalid package in |
…/desktop-wallet into refactor/pass-in-sdk-wallet
Codecov Report
@@ Coverage Diff @@
## feat/dashboard-wallet-list #2532 +/- ##
==============================================================
Coverage ? 100.00%
==============================================================
Files ? 253
Lines ? 2896
Branches ? 517
==============================================================
Hits ? 2896
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…/desktop-wallet into refactor/pass-in-sdk-wallet
Summary
Changes components that branch from the Dashboard Wallet list component. Took a while with a lot of changes so I think it may be messy in areas
Checklist