This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: High
More than 256 lines changed.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
labels
Jul 31, 2020
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2570 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 253 +229
Lines 142 2862 +2720
Branches 18 512 +494
=============================================
+ Hits 142 2862 +2720
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3 tasks
@alexbarnsley conflicts |
@faustbrian tried merging via browser as not at my main machine until tomorrow. I'll fix whatever errors have come up when I'm back at that pc |
ghost
mentioned this pull request
Aug 2, 2020
faustbrian
force-pushed
the
fix/create-wallet-bugs
branch
from
August 3, 2020 07:14
c611853
to
eae3e6b
Compare
@faustbrian thanks for updating the e2e test, I take it it was failing? Is this okay to be merged now? |
faustbrian
approved these changes
Aug 3, 2020
ghost
deleted the
fix/create-wallet-bugs
branch
August 3, 2020 12:14
ghost
mentioned this pull request
Aug 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: High
More than 256 lines changed.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes:
Checklist