Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: create wallet issues #2570

Merged
merged 16 commits into from
Aug 3, 2020
Merged

fix: create wallet issues #2570

merged 16 commits into from
Aug 3, 2020

Conversation

alexbarnsley
Copy link
Member

Summary

Fixes:

  • Quick switching between networks before wallet is generated causes network issues & duplicate wallets in the profile
  • The saving of a wallet didn't actually work as expected

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jul 31, 2020
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #2570 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2570     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       253    +229     
  Lines            142      2862   +2720     
  Branches          18       512    +494     
=============================================
+ Hits             142      2862   +2720     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c77d27...eae3e6b. Read the comment docs.

@faustbrian
Copy link
Contributor

@alexbarnsley conflicts

@alexbarnsley
Copy link
Member Author

@faustbrian tried merging via browser as not at my main machine until tomorrow. I'll fix whatever errors have come up when I'm back at that pc

@alexbarnsley
Copy link
Member Author

@faustbrian thanks for updating the e2e test, I take it it was failing?

Is this okay to be merged now?

@faustbrian faustbrian merged commit 4760f35 into 3.0-react Aug 3, 2020
@ghost ghost deleted the fix/create-wallet-bugs branch August 3, 2020 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants